Conversation
CheezItMan
reviewed
May 29, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
I gave some notes on what you have so far.
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n), where n is the length of the string |
There was a problem hiding this comment.
Technically s[0, s.length-1] creates a new string of length n-1, so this solution is actually n^2.
| # Time complexity: O(n), where n is the length of the string | ||
| # Space complexity: O(n), because there will be n layers to the call stack. | ||
| def reverse_inplace(s) | ||
| raise NotImplementedError, "Method not implemented" |
There was a problem hiding this comment.
This is not in place.
To do in-place you can create a helper method:
reverse_helper(string, left_index = 0, right_index = string.length -1)
Then each iteration you can swap the characters at left_index and right_index and then call the helper recursively with new values for left_index and right_index. The base case is when left_index == right_index.
|
|
||
| end | ||
|
|
||
| # Time complexity: ? |
| # Space complexity: ? | ||
| def bunny(n) | ||
| raise NotImplementedError, "Method not implemented" | ||
| if n % 2 == 0 |
There was a problem hiding this comment.
This should actually be:
return 0 if n == 0
return 2 + bunny(n-1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.